NR SDAP gNB - Transparent Mode
Merge request reports
Activity
added 5G-NR label
OAI RAN-Container-Parent build (630): failed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/630/)
OAI RAN-CI-develop build (2027): passed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/2027/)
changed milestone to %REVIEW_CAN_START
changed milestone to %REVIEW_IN_PROGRESS
requested review from @lthomas
assigned to @Cedric.Roux
added 198 commits
-
b5fdba70...de553cd1 - 197 commits from branch
develop
- 3421481e - NR SDAP gNB - Transparent Mode
-
b5fdba70...de553cd1 - 197 commits from branch
OAI RAN-CI-develop build (2096): passed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/2096/)
OAI RAN-Container-Parent build (698): failed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/698/)
OAI RAN-Container-Parent build (700): failed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/700/)
Code Review by : Laurent THOMAS
-
IMPACT on FUNCTIONAL CODE
- The code change does NOT respect architecture/protocol split
- Abnormal exits are NOT properly handled
-
Coding Style Issues
- Added DEAD Code
- Improper logging
- Added useless debug code
- Duplication of an existing function
- Indentation is not respected
- Insufficient in-code comments / code readability
- Any other coding style issue
- A new tool/lib/package has been introduced (blocking, subject to negotiation)
-
TESTING (The Merge Request requires additional testing)
- Additional testing is present in the Merge Request (Best)
- The contributor provides a framework/hints for testing
- New testing means need to be developed
-
DOCUMENTATION (The Merge Request requires additional documentation)
-
Feature Set documentation update needed
- DONE
- NOT DONE
-
Wiki tutorial / in-repo usage documentation needed
- DONE
- NOT DONE
-
Added/Modified/Removed script/build/runtime option(s)
- Help UPDATED
- Help NOT UPDATED
-
Feature Set documentation update needed
Recommendations:
it is accepted
Edited by Remi Hardy-
IMPACT on FUNCTIONAL CODE
changed milestone to %REVIEW_COMPLETED_AND_APPROVED
added 30 commits
-
3421481e...314760ac - 28 commits from branch
develop
- 01093063 - NR SDAP gNB - Transparent Mode
- 86161e47 - Fix: nrUE not processing SDAP header
-
3421481e...314760ac - 28 commits from branch
OAI RAN-Container-Parent build (715): passed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/715/)
OAI RAN-CI-develop build (2112): passed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/2112/)
mentioned in merge request !1297 (merged)
mentioned in commit 1b742fbe