Change variable types in statistics to accommodate more bytes and to avoid negative values
When running gNB for a long time and transferring high amount of data, statistics become negative (and later in an arithmetic overflow) because they are too short for such amount of bytes. Example: UE 0: ulsch_total_bytes_scheduled -1804219593, ulsch_total_bytes_received -1804223769
Merge request reports
Activity
changed milestone to %REVIEW_CAN_START
OAI RAN-CI-develop build (2288): failed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/2288/)
OAI RAN-Container-Parent build (911): failed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/911/)
requested review from @lthomas
Code Review by : Laurent Thomas
-
IMPACT on FUNCTIONAL CODE
- The code change does respect architecture/protocol split
- Abnormal exits are NOT properly handled
-
Coding Style Issues
- Added DEAD Code
- Improper logging
- Added useless debug code
- Duplication of an existing function
- Indentation is not respected
- Insufficient in-code comments / code readability
- Any other coding style issue
- A new tool/lib/package has been introduced (blocking, subject to negotiation)
-
TESTING (The Merge Request requires additional testing)
- Additional testing is present in the Merge Request (Best)
- The contributor provides a framework/hints for testing
- New testing means need to be developed
-
DOCUMENTATION (The Merge Request requires additional documentation)
-
Feature Set documentation update needed
- DONE
- NOT DONE
-
Wiki tutorial / in-repo usage documentation needed
- DONE
- NOT DONE
-
Added/Modified/Removed script/build/runtime option(s)
- Help UPDATED
- Help NOT UPDATED
-
Feature Set documentation update needed
Recommendations:
it is accepted
Edited by Remi Hardy-
IMPACT on FUNCTIONAL CODE
changed milestone to %REVIEW_COMPLETED_AND_APPROVED
assigned to @lthomas
unassigned @lthomas
OAI RAN-CI-develop build (2289): failed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/2289/)
OAI RAN-Container-Parent build (912): failed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/912/)
removed NSA label
added NSA label
OAI RAN-Container-Parent build (919): passed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/919/)
OAI RAN-CI-develop build (2296): passed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/2296/)
changed milestone to %OK_TO_BE_MERGED
mentioned in merge request !1320 (closed)
removed NSA label
mentioned in merge request !1322 (closed)
mentioned in merge request !1328 (merged)
mentioned in commit 5319d220