Make USRP tune_offset configurable

OAI RAN-CI-develop build (3252): Some Changed files in Merge Request DO NOT follow OAI Formatting Rules

OAI RAN-CI-develop build (3252): failed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/3252/)

added 513 commits

6135b4ab...5bf454c7 - 511 commits from branch develop
9f6b7dc6 - Make USRP tune_offset configurable
e1b090cf - Improve logging

I tried the USRP tune-offset with the nr-softmodem. To my understanding, this tune-offset would allow us to not require blocking of certain PRBs, e.g., in the N300. Correspondingly, I verified that this is indeed the case:

on 40MHz carrier, normally ul_prbblacklist = "51,52,53,54"; and the throughput is limited to ~3.5 Mbps with MCS 9
again 40 MHz, with the above path, ul_prbblacklist = "";, and ./nr-softmodem ... --tune-offset 40000000 (i.e., the tune offset equal to the bandwidth): I could use the full UL bandwidth with UL throughput ~7.5 Mbps at MCS 9 (but I have many LLL)

@luis_pereira87 : can you please reproduce? can you do the review or should I ask somebody else? The --tune-offset parameter should be available to all {lte,nr}-{,ue}softmodems. The review would simply consist in verifying that the parameter is correctly passed to USRP.

@raymond.knopp is there something else you would want me to check?

OAI RAN-CI-develop build (3438): Some Changed files in Merge Request DO NOT follow OAI Formatting Rules

OAI RAN-CI-develop build (3438): failed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/3438/)

OAI RAN-Container-Parent build (2051): failed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/2051/)

@schmidtr just some quick results that I got in uplink with this branch:

- With N300 and 162 PRBs
No uplink iPerf (100% ulsch errors for DRB)

- With N300 and 162 PRBs and ul_prbblacklist = "79,80,81,82"
[  3] 19.0-20.0 sec   679 KBytes  5.56 Mbits/sec   7.812 ms    0/  473 (0%)
[  3] 20.0-21.0 sec   680 KBytes  5.57 Mbits/sec  10.063 ms    0/  474 (0%)

- With --tune-offset 30000000 and ul_prbblacklist removed from config file
[  3]  6.0- 7.0 sec  1.37 MBytes  11.5 Mbits/sec   1.619 ms    0/  974 (0%)
[  3]  7.0- 8.0 sec  1.37 MBytes  11.5 Mbits/sec   1.176 ms    0/  975 (0%)

Code Review by : @luis_pereira87

IMPACT on FUNCTIONAL CODE
- The code change does NOT respect architecture/protocol split
- Abnormal exits are NOT properly handled
- Coding Style Issues
  - Added DEAD Code
  - Improper logging
  - Added useless debug code
  - Duplication of an existing function
  - Indentation is not respected
  - Insufficient in-code comments / code readability
  - Any other coding style issue
- A new tool/lib/package has been introduced (blocking, subject to negotiation)
TESTING (The Merge Request requires additional testing)
- Additional testing is present in the Merge Request (Best)
- The contributor provides a framework/hints for testing
- New testing means need to be developed
DOCUMENTATION (The Merge Request requires additional documentation)
- Feature Set documentation update needed
  - DONE
  - NOT DONE
- Wiki tutorial / in-repo usage documentation needed
  - DONE
  - NOT DONE
- Added/Modified/Removed script/build/runtime option(s)
  - Help UPDATED
  - Help NOT UPDATED

Recommendations:

Ok to be merged.

changed milestone to %REVIEW_COMPLETED_AND_APPROVED

approved this merge request

changed milestone to %OK_TO_BE_MERGED

mentioned in merge request !1572 (merged)

mentioned in commit 5ea828e1

merged

Make USRP tune_offset configurable

Merge request reports

Activity