Set k2=2, enable slot 0

In the past, activation of slot 0 (i.e., after the switch UL->DL) resulted in many retransmissions. This does not seem to be the case anymore, and we can therefore activate slot 0 also in TDD.

In the past, setting k2=2 for 5ms TDD periods resulted in increased ping RTT and/or reestablishment requests. These problems do not appear anymore, and we can allow k2=2. Solved #518 (closed)

changed milestone to %REVIEW_CAN_START

added 5G-NR label

requested review from @francescomani

added 1 commit

• 9354d430 - Set k2=2 also in 5ms TDD periods

Compare with previous version

resolved all threads

changed milestone to %REVIEW_IN_PROGRESS

OAI RAN-CI-develop build (3436): Merge Conflicts -- Cannot perform CI

OAI RAN-CI-develop build (3436): failed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/3436/)

OAI RAN-CI-develop build (3437): Some Changed files in Merge Request DO NOT follow OAI Formatting Rules

OAI RAN-CI-develop build (3437): passed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/3437/)

OAI RAN-Container-Parent build (2050): failed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/2050/)

changed milestone to %REVIEW_COMPLETED_AND_APPROVED

**Code Review by : @francescomani **

• IMPACT on FUNCTIONAL CODE
  • The code change does NOT respect architecture/protocol split
  • Abnormal exits are NOT properly handled
  • Coding Style Issues
    • Added DEAD Code
    • Improper logging
    • Added useless debug code
    • Duplication of an existing function
    • Indentation is not respected
    • Insufficient in-code comments / code readability
    • Any other coding style issue
  • A new tool/lib/package has been introduced (blocking, subject to negotiation)
• TESTING (The Merge Request requires additional testing)
  • Additional testing is present in the Merge Request (Best)
  • The contributor provides a framework/hints for testing
  • New testing means need to be developed
• DOCUMENTATION (The Merge Request requires additional documentation)
  • Feature Set documentation update needed
    • DONE
    • NOT DONE
  • Wiki tutorial / in-repo usage documentation needed
    • DONE
    • NOT DONE
  • Added/Modified/Removed script/build/runtime option(s)
    • Help UPDATED
    • Help NOT UPDATED

Recommendations: Ok to merge. To be tested with quectel before merge.

Hi @schmidtr @francescomani I tested with Quectel and B210 and N300.

[NR_MAC]   (874.0) SIB1 transmission: ssb_index 0
[NR_MAC]    874. 0 [DLSCH/PDSCH/PUCCH] UE 1 RNTI 7f0c DCI L 2 start   0 RBs  27 startSymbol  1 nb_symbol 13 dmrspos 804 MCS 13 nrOfLayers 1 TBS 1601 HARQ PID  1 round 0 RV 0 NDI 0 dl_data_to_ULACK 5 (874.7) PUCCH allocation 0 TPC 1
[NR_MAC]    875. 0 [DLSCH/PDSCH/PUCCH] UE 1 RNTI 7f0c DCI L 2 start   0 RBs 106 startSymbol  1 nb_symbol 13 dmrspos 804 MCS 12 nrOfLayers 1 TBS 5763 HARQ PID 14 round 0 RV 0 NDI 0 dl_data_to_ULACK 5 (875.7) PUCCH allocation 0 TPC 1
[NR_MAC]   (876.0) SIB1 transmission: ssb_index 0
[NR_MAC]    876. 0 [DLSCH/PDSCH/PUCCH] UE 1 RNTI 7f0c DCI L 2 start   0 RBs  27 startSymbol  1 nb_symbol 13 dmrspos 804 MCS 12 nrOfLayers 1 TBS 1473 HARQ PID 10 round 0 RV 0 NDI 1 dl_data_to_ULACK 5 (876.7) PUCCH allocation 0 TPC 1
[NR_MAC]    877. 0 [DLSCH/PDSCH/PUCCH] UE 1 RNTI 7f0c DCI L 2 start   0 RBs 106 startSymbol  1 nb_symbol 13 dmrspos 804 MCS 12 nrOfLayers 1 TBS 5763 HARQ PID  6 round 0 RV 0 NDI 0 dl_data_to_ULACK 5 (877.7) PUCCH allocation 0 TPC 1
[NR_MAC]   (878.0) SIB1 transmission: ssb_index 0
[NR_MAC]    878. 0 [DLSCH/PDSCH/PUCCH] UE 1 RNTI 7f0c DCI L 2 start   0 RBs  27 startSymbol  1 nb_symbol 13 dmrspos 804 MCS 12 nrOfLayers 1 TBS 1473 HARQ PID  1 round 0 RV 0 NDI 1 dl_data_to_ULACK 5 (878.7) PUCCH allocation 0 TPC 1
[NR_MAC]    879. 0 [DLSCH/PDSCH/PUCCH] UE 1 RNTI 7f0c DCI L 2 start   0 RBs 106 startSymbol  1 nb_symbol 13 dmrspos 804 MCS 12 nrOfLayers 1 TBS 5763 HARQ PID 14 round 0 RV 0 NDI 1 dl_data_to_ULACK 5 (879.7) PUCCH allocation 0 TPC 1
[NR_MAC]   (880.0) SIB1 transmission: ssb_index 0
[NR_MAC]    880. 0 [DLSCH/PDSCH/PUCCH] UE 1 RNTI 7f0c DCI L 2 start   0 RBs  27 startSymbol  1 nb_symbol 13 dmrspos 804 MCS 12 nrOfLayers 1 TBS 1473 HARQ PID 10 round 0 RV 0 NDI 0 dl_data_to_ULACK 5 (880.7) PUCCH allocation 0 TPC 1
[NR_MAC]    881. 0 [DLSCH/PDSCH/PUCCH] UE 1 RNTI 7f0c DCI L 2 start   0 RBs 106 startSymbol  1 nb_symbol 13 dmrspos 804 MCS 12 nrOfLayers 1 TBS 5763 HARQ PID  6 round 0 RV 0 NDI 1 dl_data_to_ULACK 5 (881.7) PUCCH allocation 0 TPC 1

In my setup, instead of 132 Mbps I have now only 128 Mbps because every 2 frames we have a slot with 27 PRBs allocated (because SSB and SIB1 in slot 0) while in the past we had all the slots with 106 PRBs allocated.

For me it is OK to be merged!

resolved all threads

changed milestone to %OK_TO_BE_MERGED

mentioned in merge request !1564 (merged)

merged

mentioned in issue #518 (closed)