Skip to content
Snippets Groups Projects

Putting all CM code in one file

Merged Melissa requested to merge episys-channel-model-org into develop
All threads resolved!

This commit includes reorganization of all of the SISO/MIMO channel modelling support being moved into a single CM file. Furthermore, it includes a bug fix for the number of MCS simulation tables (29 total, 0-28).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Robert Schmidt added 1 commit

    added 1 commit

    • 9c02189e - Remove nr_bler_data from physims

    Compare with previous version

  • OAI RAN-CI-develop build (3593): Some Changed files in Merge Request DO NOT follow OAI Formatting Rules

  • **Code Review by : @schmidtr **

    • IMPACT on FUNCTIONAL CODE
      • The code change does NOT respect architecture/protocol split
      • Abnormal exits are NOT properly handled
      • Coding Style Issues
        • Added DEAD Code
        • Improper logging
        • Added useless debug code
        • Duplication of an existing function
        • Indentation is not respected
        • Insufficient in-code comments / code readability
        • Any other coding style issue
      • A new tool/lib/package has been introduced (blocking, subject to negotiation)
    • TESTING (The Merge Request requires additional testing)
      • Additional testing is present in the Merge Request (Best)
      • The contributor provides a framework/hints for testing
      • New testing means need to be developed
    • DOCUMENTATION (The Merge Request requires additional documentation)
      • Feature Set documentation update needed
        • DONE
        • NOT DONE
      • Wiki tutorial / in-repo usage documentation needed
        • DONE
        • NOT DONE
      • Added/Modified/Removed script/build/runtime option(s)
        • Help UPDATED
        • Help NOT UPDATED

    Recommendations:

    to (1) say whether it is accepted and (2) say what should still be done to finalize the merge request

    • Upon my request, moving channel modelling functions for L2sim from NR_UE_PHY_INTERFACE/NR_IF_Module.c to NR_UE_PHY_INTERFACE/NR_Packet_Drop.c
    • Don't understand the name NR_Packet_Drop.c, wouldn't NR_Channel_Mod.c or something like this better? Does the channel model only decide about dropping packets? Renaming is optional
    • I remove some array from the physims that I put a couple of weeks ago to prevent linker errors
    • The above review comment is for my information.
    • It is accepted.
    Edited by Robert Schmidt
  • Robert Schmidt resolved all threads

    resolved all threads

  • Robert Schmidt mentioned in merge request !1596 (merged)

    mentioned in merge request !1596 (merged)

  • changed milestone to %OK_TO_BE_MERGED

  • Robert Schmidt mentioned in commit 6d030ea2

    mentioned in commit 6d030ea2

  • Please register or sign in to reply
    Loading