Support Fedora 36
- Bump Fedora 36 in
build_oai
- Remove unneeded package
- Check
RHEL_VERSION_CODE
that it is not Fedora (version 9.99)
Merge request reports
Activity
changed milestone to %REVIEW_CAN_START
requested review from @lthomas
OAI RAN-Container-Parent build (2209): failed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/2209/)
OAI RAN-CI-develop build (3577): failed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/3577/)
added 1 commit
- 2124e43d - Correctly use RHEL_RELEASE_CODE for Fedora and RHEL
OAI RAN-CI-develop build (3582): failed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/3582/)
OAI RAN-Container-Parent build (2214): failed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/2214/)
removed 5G-NR label
removed 4G-LTE label
added BUILD-ONLY label
added 1 commit
- 0fe98c25 - Avoid RHEL_RELEASE_VERSION: not defined in Ubuntu
OAI RAN-Container-Parent build (2217): passed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/2217/)
OAI RAN-CI-develop build (3585): passed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/3585/)
**Code Review by : Laurent THOMAS **
-
IMPACT on FUNCTIONAL CODE
- The code change does respect architecture/protocol split
- Abnormal exits are properly handled
-
Coding Style Issues
- Added DEAD Code
- Improper logging
- Added useless debug code
- Duplication of an existing function
- Indentation is not respected
- Insufficient in-code comments / code readability
- Any other coding style issue
- A new tool/lib/package has been introduced (blocking, subject to negotiation)
-
TESTING (The Merge Request requires additional testing)
- Additional testing is present in the Merge Request (Best)
- The contributor provides a framework/hints for testing
- New testing means need to be developed
-
DOCUMENTATION (The Merge Request requires additional documentation)
-
Feature Set documentation update needed
- DONE
- NOT DONE
-
Wiki tutorial / in-repo usage documentation needed
- DONE
- NOT DONE
-
Added/Modified/Removed script/build/runtime option(s)
- Help UPDATED
- Help NOT UPDATED
-
Feature Set documentation update needed
Recommendations:
it is accepted
-
IMPACT on FUNCTIONAL CODE
changed milestone to %REVIEW_COMPLETED_AND_APPROVED
changed milestone to %OK_TO_BE_MERGED
mentioned in merge request !1596 (merged)
mentioned in commit 6d030ea2