Skip to content
Snippets Groups Projects

fix encoding error in mbms by regrouping the missing barrier at a single level

Merged Thomas Laurent requested to merge fix-lte-mbms into develop
All threads resolved!

The mbms author copied the encoding function to make a new flavor for mbms but he missed to copy the barrier after the asynchronous launch of turbo encode so, data is following process take input regardless it is already ready or not

the fix moves the barrier at a common position between this new mbms feature and the regular DL coding

Edited by Robert Schmidt

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Robert Schmidt

      @lthomas there is some work about threads, is it related to mbms?

      Also I see that you removed some time measurements about turbo coding. It is not clear to me if it was used or not.

      It would have been nice to isolate those two things in separate commits, or even other merge requests, if they are not related to mbms.

  • changed milestone to %REVIEW_IN_PROGRESS

  • Cédric Roux resolved all threads

    resolved all threads

  • as far as the CI is fine, this is accepted for merge.

  • Thomas Laurent added 16 commits

    added 16 commits

    • 45610c8e...af04fa90 - 14 commits from branch develop
    • 50879829 - fix encoding error in mbms by regrouping the missing barrier at a single level
    • 28224159 - remove unused variables

    Compare with previous version

  • Robert Schmidt resolved all threads

    resolved all threads

  • changed milestone to %OK_TO_BE_MERGED

  • Robert Schmidt mentioned in merge request !1636 (merged)

    mentioned in merge request !1636 (merged)

  • Robert Schmidt mentioned in merge request !1722 (merged)

    mentioned in merge request !1722 (merged)

  • Robert Schmidt mentioned in commit bb396052

    mentioned in commit bb396052

  • Please register or sign in to reply
    Loading