fix encoding error in mbms by regrouping the missing barrier at a single level
The mbms author copied the encoding function to make a new flavor for mbms but he missed to copy the barrier after the asynchronous launch of turbo encode so, data is following process take input regardless it is already ready or not
the fix moves the barrier at a common position between this new mbms feature and the regular DL coding
Merge request reports
Activity
OAI RAN-CI-develop build (4143): failed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/4143/)
added 4G-LTE label
requested review from @Cedric.Roux
OAI RAN-CI-develop build (4144): passed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/4144/)
OAI RAN-Container-Parent build (2753): failed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/2753/)
- Resolved by Cédric Roux
- Resolved by Robert Schmidt
@lthomas there is some work about threads, is it related to mbms?
Also I see that you removed some time measurements about turbo coding. It is not clear to me if it was used or not.
It would have been nice to isolate those two things in separate commits, or even other merge requests, if they are not related to mbms.
changed milestone to %REVIEW_IN_PROGRESS
changed milestone to %REVIEW_COMPLETED_AND_APPROVED
added 16 commits
-
45610c8e...af04fa90 - 14 commits from branch
develop
- 50879829 - fix encoding error in mbms by regrouping the missing barrier at a single level
- 28224159 - remove unused variables
-
45610c8e...af04fa90 - 14 commits from branch
OAI RAN-CI-develop build (4169): passed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/4169/)
OAI RAN-Container-Parent build (2778): failed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/2778/)
changed milestone to %OK_TO_BE_MERGED
mentioned in merge request !1636 (merged)
mentioned in merge request !1722 (merged)
mentioned in commit bb396052