Skip to content
Snippets Groups Projects

Fixes to improve CI

Merged Robert Schmidt requested to merge fixes-ci into develop
1 unresolved thread
  • Tpool: signal condition variable using condbroadcast()
  • various configuration file improvements
  • I have seen that the RAN-NSA-B200-Module-LTEBOX-Container's eNB log is empty, I need to debug, this is why it often fails now (apart from the fact that sometimes the gNB is in a dead lock) -> the docker-compose version was old and did not know the --no-log-prefix option that is used in the CI
Edited by Robert Schmidt

Merge request reports

Approval is optional

Merged by Robert SchmidtRobert Schmidt 2 years ago (Nov 25, 2022 6:44am UTC)

Merge details

  • Changes merged into develop with 8773e423.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
237 237 if (nf->outF == NULL)
238 238 nf->inF = NULL;
239 239 mutexunlock(nf->lockF);
240 condsignal(nf->notifF);
240 condbroadcast(nf->notifF);
  • Author Maintainer

    @lthomas I changed this because I remarked that some Tpool worker threads would still hang on a notifF. However, after making this change, I have observed that at least once more. Do you sometimes observe the gNB being in a deadlock when stopping it?

  • Please register or sign in to reply
  • Robert Schmidt changed the description

    changed the description

  • Consolidated Test Results
    Tested CommitID: 1dc45423
    RAN-LTE-2x2-Module-OAIEPC: SUCCESS (672)
    RAN-NSA-B200-Module-LTEBOX: FAILURE (1747)
    RAN-NSA-2x2-Module-OAIEPC: FAILURE (647)
    RAN-SA-Module-CN5G: FAILURE (758)
    RAN-SA-AmariS-CN5G: SUCCESS (196)
    RAN-SA-OAIUE-N310-X300-CN5G: FAILURE (434)

  • Consolidated Test Results
    Tested CommitID: 1dc45423
    RAN-LTE-2x2-Module-OAIEPC: FAILURE (673)
    RAN-NSA-B200-Module-LTEBOX: FAILURE (1748)
    RAN-NSA-2x2-Module-OAIEPC: FAILURE (648)
    RAN-SA-Module-CN5G: FAILURE (763)
    RAN-SA-AmariS-CN5G: FAILURE (198)
    RAN-SA-OAIUE-N310-X300-CN5G: FAILURE (435)

  • removed NSA label

  • Robert Schmidt changed the description

    changed the description

  • Thomas Laurent requested review from @lthomas

    requested review from @lthomas

  • **Code Review by : Laurent THOMAS**
    
    *  [X] **IMPACT on FUNCTIONAL CODE**  
       -  [X]  The code change does respect architecture/protocol split  
       -  [ ]  Abnormal exits are **NOT** properly handled  
       -  [ ]  Coding Style Issues  
          *  [ ] Added DEAD Code  
          *  [ ] Improper logging  
          *  [ ] Added useless debug code  
          *  [ ] Duplication of an existing function  
          *  [ ] Indentation is not respected  
          *  [ ] Insufficient in-code comments / code readability  
          *  [ ] Any other coding style issue  
       -  [ ]  A new tool/lib/package has been introduced (**blocking, subject to negotiation**)  
    *  [ ] **TESTING** (The Merge Request requires additional testing)  
       -  [ ]  Additional testing is present in the Merge Request (Best)  
       -  [ ]  The contributor provides a framework/hints for testing  
       -  [ ]  New testing means need to be developed  
    *  [ ] **DOCUMENTATION** (The Merge Request requires additional documentation)  
       -  [ ]  Feature Set documentation update needed  
          * [ ] DONE
          * [ ] NOT DONE  
       -  [ ]  Wiki tutorial / in-repo usage documentation needed  
          * [ ] DONE
          * [ ] NOT DONE  
       -  [ ]  Added/Modified/Removed script/build/runtime option(s)  
          * [ ] Help UPDATED
          * [ ] Help NOT UPDATED  
    
    Recommendations: consider to:
    it is accepted 
  • changed milestone to %OK_TO_BE_MERGED

  • Robert Schmidt mentioned in merge request !1832 (merged)

    mentioned in merge request !1832 (merged)

  • Robert Schmidt mentioned in commit 8773e423

    mentioned in commit 8773e423

  • Please register or sign in to reply
    Loading