Fixes to improve CI
1 unresolved thread
1 unresolved thread
-
Tpool: signal condition variable using condbroadcast()
-
various configuration file improvements -
I have seen that the RAN-NSA-B200-Module-LTEBOX-Container's eNB log is empty, I need to debug, this is why it often fails now (apart from the fact that sometimes the gNB is in a dead lock)-> the docker-compose version was old and did not know the--no-log-prefix
option that is used in the CI
Edited by Robert Schmidt
Merge request reports
Activity
237 237 if (nf->outF == NULL) 238 238 nf->inF = NULL; 239 239 mutexunlock(nf->lockF); 240 condsignal(nf->notifF); 240 condbroadcast(nf->notifF); @lthomas I changed this because I remarked that some Tpool worker threads would still hang on a
notifF
. However, after making this change, I have observed that at least once more. Do you sometimes observe the gNB being in a deadlock when stopping it?
removed NSA label
requested review from @lthomas
changed milestone to %REVIEW_COMPLETED_AND_APPROVED
**Code Review by : Laurent THOMAS** * [X] **IMPACT on FUNCTIONAL CODE** - [X] The code change does respect architecture/protocol split - [ ] Abnormal exits are **NOT** properly handled - [ ] Coding Style Issues * [ ] Added DEAD Code * [ ] Improper logging * [ ] Added useless debug code * [ ] Duplication of an existing function * [ ] Indentation is not respected * [ ] Insufficient in-code comments / code readability * [ ] Any other coding style issue - [ ] A new tool/lib/package has been introduced (**blocking, subject to negotiation**) * [ ] **TESTING** (The Merge Request requires additional testing) - [ ] Additional testing is present in the Merge Request (Best) - [ ] The contributor provides a framework/hints for testing - [ ] New testing means need to be developed * [ ] **DOCUMENTATION** (The Merge Request requires additional documentation) - [ ] Feature Set documentation update needed * [ ] DONE * [ ] NOT DONE - [ ] Wiki tutorial / in-repo usage documentation needed * [ ] DONE * [ ] NOT DONE - [ ] Added/Modified/Removed script/build/runtime option(s) * [ ] Help UPDATED * [ ] Help NOT UPDATED Recommendations: consider to: it is accepted
changed milestone to %OK_TO_BE_MERGED
mentioned in merge request !1832 (merged)
mentioned in commit 8773e423
Please register or sign in to reply