Improvements in 5G RAR and DCI for initial BWP larger than 180PRBs
Merge request reports
Activity
added 5G-NR label
OAI RAN-CI-develop build (4971): passed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/4971/)
OAI RAN-Container-Parent build (3564): failed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/3564/)
changed milestone to %REVIEW_CAN_START
requested review from @luis_pereira87
changed milestone to %REVIEW_IN_PROGRESS
Code Review by : @luis_pereira87
-
IMPACT on FUNCTIONAL CODE
- The code change does NOT respect architecture/protocol split
- Abnormal exits are NOT properly handled
-
Coding Style Issues
- Added DEAD Code
- Improper logging
- Added useless debug code
- Duplication of an existing function
- Indentation is not respected
- Insufficient in-code comments / code readability
- Any other coding style issue
- A new tool/lib/package has been introduced (blocking, subject to negotiation)
-
TESTING (The Merge Request requires additional testing)
- Additional testing is present in the Merge Request (Best)
- The contributor provides a framework/hints for testing
- New testing means need to be developed
-
DOCUMENTATION (The Merge Request requires additional documentation)
-
Feature Set documentation update needed
- DONE
- NOT DONE
-
Wiki tutorial / in-repo usage documentation needed
- DONE
- NOT DONE
-
Added/Modified/Removed script/build/runtime option(s)
- Help UPDATED
- Help NOT UPDATED
-
Feature Set documentation update needed
Recommendations:
- Ok to be merged.
-
IMPACT on FUNCTIONAL CODE
changed milestone to %REVIEW_COMPLETED_AND_APPROVED
OAI RAN-Container-Parent build (3600): failed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/3600/)
changed milestone to %OK_TO_BE_MERGED
mentioned in merge request !1877 (merged)
mentioned in commit 1a0c0cd1
Please register or sign in to reply