NAS Service Request enc/dec implementation

NAS Service Request:

• encoding
• decoding
• unit test

Related to #852

changed milestone to %REVIEW_CAN_START

added 5G-NR label

assigned to @guidocasati

To be merged after !2980 (merged) and !2984 (merged)

mentioned in issue #852

added 94 commits

• 7449841d...6c1d94a3 - 90 commits from branch develop
• 7498a967 - Rename FGS Service Request/Reject/Accept type for consistency with FGS naming style
• 3a99f8df - NAS Service Request implementation
• c363ff73 - Refactor TLVDecoder macros
• 6b36acb1 - Add test for NAS Service Request enc/dec

Compare with previous version

marked this merge request as ready

changed the description

requested review from @Cedric.Roux

OAI RAN-Container-Parent build (10791): failed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/10791/)

List of failing test stages:

• RAN-SA-OAIUE-CN5G
• RAN-SA-B200-Module-SABOX-Container
• RAN-RF-Sim-Test-5G

don't use these variables;

rather, define corresponding OBJECT libraries

changed this line in version 3 of the diff

done

added 2 commits

• 633044ac - Refactor TLVEncoder
• 57382a67 - Add test for NAS Service Request enc/dec

Compare with previous version

OAI RAN-Container-Parent build (10813): failed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/10813/)

List of failing test stages:

• RAN-SA-AW2S-CN5G
• RAN-SA-2x2-Module-CN5G
• RAN-RF-Sim-Test-5G
• RAN-SA-B200-Module-SABOX-Container
• RAN-SA-OAIUE-CN5G

changed milestone to %REVIEW_IN_PROGRESS

Seems to me that proper checking of input data for decoding is not super good. Also checks on buffer size for encoding don't seem good. Reading a bit more the NAS it seems that it's the same for previous code, so I would say it's okay to accept this new message, which is similar to what is already there (provided I understood things correctly).

At some point we will need to do something better. (Thinking in terms of security.)

added 71 commits

• 57382a67...220d851d - 62 commits from branch develop
• 010627ce - Rename FGS Service Request/Reject/Accept type for consistency with FGS naming style
• c47570f3 - Cleanup test5Gnas.c and MAC references in NR_NAS_defs.h (undefined functions prototypes)
• 680b7544 - Refactor NAS Key Set Identifier enc/dec functions
• 0378816d - Add check on minimum length in encode_5gs_mobile_identity
• 4c190cf7 - Add include for stdbool.h in FGSMobileIdentity.c
• 4b8d47dd - Add NAS Service Request enc/dec functions
• 35c44d0f - Refactor TLVDecoder macros
• 34a32b78 - Refactor TLVEncoder
• f9e3c5e0 - Add test for NAS Service Request enc/dec

Compare with previous version

Addressed most of the comments. Remaining to address: error handling in enc/dec functions and security context check.

OAI RAN-Container-Parent build (10970): failed (https://jenkins-oai-public.apps.oai.cs.eurecom.fr/job/RAN-Container-Parent/10970/)

List of failing test stages:

• RAN-Interop-F1
• RAN-SA-AW2S-CN5G
• RAN-SA-B200-Module-SABOX-Container
• RAN-RF-Sim-Test-5G

mentioned in commit 22255636

added 102 commits

• f9e3c5e0...f54ca571 - 93 commits from branch develop
• 139289c3 - Rename FGS Service Request/Reject/Accept type for consistency with FGS naming style
• d364dfbb - Cleanup test5Gnas.c and MAC references in NR_NAS_defs.h (undefined functions prototypes)
• 8aa86107 - Refactor NAS Key Set Identifier enc/dec functions
• 0f2a31bc - Add check on minimum length in encode_5gs_mobile_identity
• 8ed768c9 - Add include for stdbool.h in FGSMobileIdentity.c
• 5fd3a38c - Add NAS Service Request enc/dec functions
• 3821fd71 - Refactor TLVDecoder macros
• a432aca7 - Refactor TLVEncoder
• b7112dd6 - Add test for NAS Service Request enc/dec

Compare with previous version

OAI RAN-Container-Parent build (11041): failed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/11041/)

List of failing test stages:

• RAN-Ubuntu18-Image-Builder

Addressed the first round of review.

mentioned in commit 3861d218

added 63 commits

• b7112dd6...68191088 - 54 commits from branch develop
• 8a7321db - Rename FGS Service Request/Reject/Accept type for consistency with FGS naming style
• 5c3953b6 - Cleanup test5Gnas.c and MAC references in NR_NAS_defs.h (undefined functions prototypes)
• bf776113 - Refactor NAS Key Set Identifier enc/dec functions
• 29220a60 - Add check on minimum length in encode_5gs_mobile_identity
• c817c44a - Add include for stdbool.h in FGSMobileIdentity.c
• 1c4e1029 - Add NAS Service Request enc/dec functions
• ad412028 - Refactor TLVDecoder macros
• 6faa5d30 - Refactor TLVEncoder
• 44c9dec6 - Add test for NAS Service Request enc/dec

Compare with previous version

OAI RAN-Container-Parent build (11170): failed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/11170/)

List of failing test stages:

• RAN-SA-AERIAL-CN5G
• RAN-gNB-N300-Timing-Phytest-LDPC
• RAN-SA-2x2-Module-CN5G
• RAN-SA-AW2S-CN5G
• RAN-SA-OAIUE-CN5G
• RAN-PhySim-Cluster
• RAN-SA-B200-Module-SABOX-Container
• RAN-RF-Sim-Test-5G
• RAN-NSA-B200-Module-LTEBOX-Container

marked this merge request as draft

marked this merge request as ready

OAI RAN-Container-Parent build (11201): failed (https://jenkins-oai.eurecom.fr/job/RAN-Container-Parent/11201/)

List of failing test stages:

• RAN-SA-AERIAL-CN5G
• RAN-gNB-N300-Timing-Phytest-LDPC
• RAN-SA-AW2S-CN5G
• RAN-SA-OAIUE-CN5G
• RAN-SA-2x2-Module-CN5G
• RAN-SA-B200-Module-SABOX-Container
• RAN-RF-Sim-Test-5G
• RAN-SA-FHI72-CN5G

mentioned in merge request !2725 (merged)

mentioned in commit 5eca908b

changed milestone to %REVIEW_COMPLETED_AND_APPROVED

changed milestone to %OK_TO_BE_MERGED

mentioned in commit 2fad0001

mentioned in merge request !3148 (merged)

mentioned in commit 054506f5

merged with merge request !3148 (merged)

mentioned in commit e03c15e8