dft in shared lib

dfts/idfts code now compiled in libdfts.so, dynamically loaded at run-time. Now one entry point for dft and one for idft, first parameter indentifies the required dft/idft size. All dft/idft callers updated. One function (load_dftslib() in ../openair1/PHY/TOOLS/dfts_load.c) added to load the dfts library. lte_dfts.c renamed to oai_dfts.c, as it is used also for 5G...dft init function is now called automatically when dft library is loaded.

added code cleanup label

OAI RAN-CI-develop build (393): Some Changed files in Merge Request DO NOT follow OAI Formatting Rules

OAI RAN-CI-develop build (393): Some modified files in Merge Request MAY have INTRODUCED up to 1 CPPCHECK errors/warnings

OAI RAN-CI-develop build (393): failed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/393/)

OAI RAN-CI-develop build (394): Some Changed files in Merge Request DO NOT follow OAI Formatting Rules

@frtabu

I relaunched it. Protobuf failed to install in one of the VM build. Go figure?

Raphael

Might be a problem accessing some install repo? I re-check builds (but without -I) it runs fine for me.

OAI RAN-CI-develop build (394): Some modified files in Merge Request MAY have INTRODUCED up to 1 CPPCHECK errors/warnings

OAI RAN-CI-develop build (394): failed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/394/)

@frtabu

again --> the install of protobuf failed because github download failed

I need to get a workaround for that

Downloading protobuf
--2020-04-02 11:40:07--  https://github.com/google/protobuf/releases/download/v3.3.0/protobuf-cpp-3.3.0.tar.gz
Resolving github.com (github.com)... 140.82.118.3
Connecting to github.com (github.com)|140.82.118.3|:443... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: https://github.com/protocolbuffers/protobuf/releases/download/v3.3.0/protobuf-cpp-3.3.0.tar.gz [following]
--2020-04-02 11:40:07--  https://github.com/protocolbuffers/protobuf/releases/download/v3.3.0/protobuf-cpp-3.3.0.tar.gz
Reusing existing connection to github.com:443.
HTTP request sent, awaiting response... 500 internal server error
2020-04-02 11:40:08 ERROR 500: internal server error.

If there is a problem accessing a repo what could you do?? May be we could build a VM where packages are already installed and just have one scenario testing the -I option, which failure could be "non fatal".

I would like to try something like wget --tries=3 --retry-connrefused ....

added 1 commit

• 657a42fe - CI: during VM builds, we often have connection issues. Adding retry options to wget

Compare with previous version

Let see. It won't hurt.

OAI RAN-CI-develop build (396): Some Changed files in Merge Request DO NOT follow OAI Formatting Rules

OAI RAN-CI-develop build (396): Some modified files in Merge Request MAY have INTRODUCED up to 1 CPPCHECK errors/warnings

OAI RAN-CI-develop build (396): failed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/396/)

@defosseu Just saw your discussion. We might consider installing protobuf through the package manager, Ubuntu 18.04 has the right version, but 16.04 has not, so maybe we can have some PPA, would that be an option?

@schmidtr

The "retry" fix I made seems to be better.

The main issue when using package from PPM is making sure we have the correct version.

Raphael