Fix data transmission in "do-ra" mode
UL and DL Traffic works now in do-ra mode, but there are still some PUCCH issues remaining. These issues are harming the acknowledgement of DL packets, and thus leading to unnecessary retransmissions. The relevant warnings at UE are:
PUCCH Invalid pucch resource indicator: at line 1082 in function select_pucch_resource of file openair1/SCHED_NR_UE/pucch_uci_ue_nr.c
and
PUCCH Error for number of bits for acknowledgment : at line 909 in function get_downlink_ack of file openair1/SCHED_NR_UE/pucch_uci_ue_nr.c
Note: UE needs rbconfig.raw and reconfig.raw files from the currently running gNB, as the C-RNTI is random and different for each run.
Merge request reports
Activity
OAI RAN-CI-develop build (1007): failed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/1007/)
added 5G-NR + 1 deleted label
Code Review by : Shweta Shrivastava
-
IMPACT on FUNCTIONAL CODE
- The code change does NOT respect architecture/protocol split
- Abnormal exits are NOT properly handled
-
Coding Style Issues
- Added DEAD Code
- Improper logging
- Added useless debug code
- Duplication of an existing function
- Indentation is not respected
- Insufficient in-code comments / code readability
- Any other coding style issue
- A new tool/lib/package has been introduced (blocking, subject to negotiation)
-
TESTING (The Merge Request requires additional testing)
- Additional testing is present in the Merge Request (Best)
- The contributor provides a framework/hints for testing
- New testing means need to be developed
-
DOCUMENTATION (The Merge Request requires additional documentation)
-
Feature Set documentation update needed
- DONE
- NOT DONE
-
Wiki tutorial / in-repo usage documentation needed
- DONE
- NOT DONE
-
Added/Modified/Removed script/build/runtime option(s)
- Help UPDATED
- Help NOT UPDATED
-
Feature Set documentation update needed
Recommendations:
- Good to merge
-
IMPACT on FUNCTIONAL CODE
added 153 commits
-
05d4b920...b9b2f289 - 152 commits from branch
develop
- ac73df69 - Merge branch 'develop' into 'fix_do_ra_data'
-
05d4b920...b9b2f289 - 152 commits from branch
OAI RAN-CI-develop build (1048): failed (https://open5glab.eurecom.fr:8083/jenkins/job/RAN-CI-develop/1048/)