- removed some whitespace noise.
 - cleaned up CMakeLists.txt
 - reintegrated task_manager.c into thread-pool.c
 - cleaned up some unnecessary code

Co-authored-by: Cedric Roux <cedric.roux@eurecom.fr>
Co-authored-by: Mikel Irazabal <mikel.irazabal@openairinterface.com>

Integration: `2024.w48`

See merge request !3134

* !2951 Integrate Tracy with NR UE
* !2985 E1AP Bearer Context Setup encoding/decoding library and unit tests
* !3115 T2: minor fix for 4x4 processing
* !3117 F1AP lib: minor fixes
* !3126 NR MSG3 scheduling improvements
* !3128 NR UE RRC T304 in phy-test mode
* !3132 Run the last job of gNB pusch channel estimation inline
* !3133 NR UL HARQ handling improvements
* !3091 Update NR UE threading model
* !3030 Imscope updates
* !3131 FAPI P7 Refactoring and unitary test creation
* !3033 Increase the number of UE supported at gNB by having more than 1 PUCCH2 frequency occasion per slot

Increase the number of UE supported at gNB by having more than 1 PUCCH2
frequency occasion per slot

FAPI P7 Refactoring and unitary test creation

This MR is a follow-up to the work done in !2714 this time separating
the P7 FAPI messages into its own library (nr_fapi_p7).

In the same way, utility functions to copy, free and compare have been
added for each message, as well as an addition function to get the
allocated size for a message, which is used for the messages that can be
too big to fit in a buffer that's allocated in the stack.

Unitary tests have been added for each of the messages, testing
pack/unpack and the utility functions added.

Imscope updates

- Using imgui docking branch - allows window docking.
- Moved scopes to different windows to allow docking.
- Disabled scatterplot for time domain samples - issues with amount of
  vertices caused segfaults.
- Disabled IQ heatmaps for RX IQ samples on gNB and UE - this was
  incorrect and currently I don't know how to fix it. This will be
  reenabled once it is.
- added a simple menu and disabled demo windows by default.

Merge remote-tracking branch 'origin/nr-ue-threading-improvements' into integration_2024_w48 (!3091)

Update NR UE threading model

This updates the NR UE threading model by preventing calling threadpool
from threadpool and fixes deadlock issues related to processSlotTX. By
making processSlotTX run to completion instead of starting and waiting
for other threads to finish it prevents locking thread pool cores,
therefore prevening deadlocks.

There is a slight difference here compared to the previous version where
I do not use the UL actor as I believe it is not necessary,
processSlotTX satisfies the run-to-completion requirement now. If in the
future any UL procedure would be parallelized using the thread pool it
should either be done in a run-to-completion model or the processSlotTX
function should be taken off the thread pool.

The documentation has been updated.

Added slot and frame to gNbTimeDomainSamples in imscope

 - Using imgui docking branch - allows window docking.
 - Moved scopes to different windows to allow docking.
 - Disabled scatterplot for time domain samples - issues with amount of vertices caused segfaults.
 - Disabled IQ heatmaps for RX IQ samples on gNB and UE - this was incorrect and currently I don't know
   how to fix it. This will be reenabled once it is.
 - added a simple menu and disabled demo windows by default.

4G/5G FAPI code is located in the same file. Since 5G code calls 5G
specific functions, these functions need to be defined in 4G.

The solution would be to separate the FAPI changes into 4G and 5G.

Rúben Soares Silva authored 5 months ago and Robert Schmidt committed 3 months ago

Add nr_fapi_p7 library to NFAPI_USER_LIB for access to utility functions

Change message handlers to use the utility functions to  copy and properly free the messages

Change the SRS handler to call the handler for the measurements instead of trying to copy to RC.gNB[0], which does not exist

Change nfapi_nr_p7_message_unpack to not allocate unneeded memory

Rúben Soares Silva authored 5 months ago and Robert Schmidt committed 3 months ago

Changed parameter in unpack function to be inline with other unpack functions.
Changed nfapi_p7_allocate call to calloc to avoid dependency to NFAPI_LIB.

Added unitary test for RACH.indication( test pack/unpack, free, copy and compare )
Added constant NFAPI_NR_RACH_IND_MAX_PDU to follow constants related to other P7 messages limiting the maximum number of PDUs to use.

Removed now unneeded dependency to NFAPI_LIB and NFAPI_USER_LIB

Rúben Soares Silva authored 5 months ago and Robert Schmidt committed 3 months ago

Extra utility function to calculate allocated memory added.

Rúben Soares Silva authored 5 months ago and Robert Schmidt committed 3 months ago

Changed parameter in unpack_nr_srs_indication to void * to be inline with other unpack procedures.
Added memory allocation for pdu_list inside unpack function.

Add unitary test for SRS.indication( test pack/unpack, free, copy and compare )
Added rands16 to provide random int16_t values, needed for SRS.indication unitary test
Added constant NFAPI_NR_SRS_IND_MAX_PDU to follow constants related to other P7 messages limiting the maximum number of PDUs to use.

Rúben Soares Silva authored 5 months ago and Robert Schmidt committed 3 months ago

This adds the equality, free and copy functions for SRS.indication message as described in the Table 3–129 of SCF222.10.04, it does not add the functions for the report type structures, as these are always sent/received inside the uint32_t array.
The utility functions for these will be added at a later commit, and subsequently tested in the upcoming unitary test for SRS.indication.
Extra utility function to calculate allocated memory added.

Rúben Soares Silva authored 3 months ago and Robert Schmidt committed 3 months ago

When using Aerial, the Report TLV on SRS.indication is transported in a different buffer, as such, it needs to be unpacked separately.

Rúben Soares Silva authored 5 months ago and Robert Schmidt committed 3 months ago

Since report_tlv->length is in bytes, and the value is an array of uint32_t, the number of uint32_t to be pushed/pulled is (length + 3) /4.

Rúben Soares Silva authored 5 months ago and Robert Schmidt committed 3 months ago

Fixes the pack/unpack functions to allow multiple reported symbols, instead of just one.
Applied clang-format to both functions.

Rúben Soares Silva authored 5 months ago and Robert Schmidt committed 3 months ago

Apply clang-format to pack/unpack procedures.
Add comments to improve readability of iqSize usage.
Fix unpacking return value to not return 0 on success.

Rúben Soares Silva authored 5 months ago and Robert Schmidt committed 3 months ago

Adds the packing/unpacking procedures for Channel SVD Representation ( Table 3-133 ).

Rúben Soares Silva authored 5 months ago and Robert Schmidt committed 3 months ago

Adds the structure for Channel SVD Representation ( Table 3-133 ), a missing report type for the SRS.indication message.

Rúben Soares Silva authored 5 months ago and Robert Schmidt committed 3 months ago

Renames nfapi_nr_srs_reported_symbol_t prgs into *reported_symbol_list for two reasons:
  So that the name is more representative of what the parameter represents.
  For it to actually be a list, and not assume only 1 reported symbol is used.

Allocate reported_symbol_list in unpack_nr_srs_beamforming_report.

Updated all references to prior prgs to point to the first position of reported_symbol_list, still only effectively using the first reported_symbol.

Rename fill_srs_reported_symbol_list into fill_srs_reported_symbol and update input parameter name, since it only fills the information related to one reported symbol

Rúben Soares Silva authored 5 months ago and Robert Schmidt committed 3 months ago

Reordered PDU pack/unpack function to follow PDU value order
Changed nfapi_p7_allocate calls to calloc to avoid dependency from FAPI lib to nFAPI lib.
Add unitary test for UCI.indication( test pack/unpack, free, copy and compare )

Rúben Soares Silva authored 5 months ago and Robert Schmidt committed 3 months ago

Fix PUCCH Format2/3/4 value to be indexed at 0, not 2.
This is according to Table 3-66 of SCF222.10.02

Add utility functions related to UCI.indication
Extra utility function to calculate allocated memory added.

Rúben Soares Silva authored 5 months ago and Robert Schmidt committed 3 months ago

Changed parameter of `unpack_nr_crc_indication` to void* to stay inline with other unpack procedures.
Changed nfapi_p7_allocate call to calloc to avoid dependency from FAPI lib to nFAPI lib.

Add unitary test for CRC.indication( test pack/unpack, free, copy and compare )

Rúben Soares Silva authored 5 months ago and Robert Schmidt committed 3 months ago

Now allocates memory for `uint8_t* cb_crc_status` before pulling in unpack procedure.

Add utility functions related to CRC.indication.
Extra utility function to calculate allocated memory added.

Rúben Soares Silva authored 5 months ago and Robert Schmidt committed 3 months ago

Changed parameter of unpack_nr_rx_data_indication to void* to be inline with other unpack procedures.
Changed nfapi_p7_allocate calls to calloc to avoid dependency from FAPI lib to nFAPI lib.
Add unitary test for RX_DATA.indication( test pack/unpack, free, copy and compare )

Rúben Soares Silva authored 5 months ago and Robert Schmidt committed 3 months ago

Changes pack/unpack procedure to expect pdu_length of 32 bits instead of 16.
This change was first added for compatibility with Aerial L1.

Add utility functions related to RX_DATA.indication
Extra utility function to calculate allocated memory added.

Rúben Soares Silva authored 6 months ago and Robert Schmidt committed 3 months ago

Add unitary test for TX_DATA.request( test pack/unpack, free, copy and compare )

Rúben Soares Silva authored 6 months ago and Robert Schmidt committed 3 months ago

Allocate memory for TX_DATA.request TLV value pointer on tag == 1
In the past, this wasn't noticed because tag == 1 is not used

Add utility functions related to TX_DATA.request
Add extra function to calculate allocated memory

Rúben Soares Silva authored 6 months ago and Robert Schmidt committed 3 months ago

Add unitary test for UL_DCI.request ( test pack/unpack, free, copy and compare )

Rúben Soares Silva authored 6 months ago and Robert Schmidt committed 3 months ago

Remove value hardcode in packing function

Add utility functions related to UL_DCI.request

Rúben Soares Silva authored 6 months ago and Robert Schmidt committed 3 months ago

Add unitary test for SLOT.indication ( test pack/unpack, free, copy and compare )

Rúben Soares Silva authored 6 months ago and Robert Schmidt committed 3 months ago

Add utility functions related to SLOT.indication