Skip to content
Snippets Groups Projects

Use F1 internally: RRC Message Transfer

Merged Robert Schmidt requested to merge int-f1-if into develop

First MR in a series of changes to use the F1 interface internally at the gNB.

  • RRC Reject not handled yet via F1 message exchange
  • Removes ITTISIM (which does not compile)
  • Refactors code duplication of linear allocator of gNB/eNB RRC
Edited by Robert Schmidt

Merge request reports

Checking pipeline status.

Merged by Robert SchmidtRobert Schmidt 2 years ago (Aug 12, 2022 5:33am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Robert Schmidt added 344 commits

    added 344 commits

    • 0bfcacfd...5bf454c7 - 337 commits from branch develop
    • 14529aa2 - Use F1 DL RRC message transfer internally for RRCSetup
    • e548714b - Add MAC-RRC UL stubs for F1AP and direct
    • 324ab08f - Do not initialize MAC multiple times
    • 7c042f84 - Refactor linear allocator from LTE/NR; separate LTE/NR headers
    • 8cd57b80 - Delete ITTI-SIM
    • 0f5f3597 - Transfer Initial UL RRC Message through internal F1
    • ad735d43 - gNB RRC: handle F1AP_UL_RRC_MESSAGE

    Compare with previous version

  • Robert Schmidt resolved all threads

    resolved all threads

  • OAI RAN-CI-develop build (3417): Some Changed files in Merge Request DO NOT follow OAI Formatting Rules

  • Robert Schmidt added 75 commits

    added 75 commits

    • ad735d43...5ea828e1 - 68 commits from branch develop
    • 076b0c6c - Use F1 DL RRC message transfer internally for RRCSetup
    • a2e27fd8 - Add MAC-RRC UL stubs for F1AP and direct
    • 4b00b029 - Do not initialize MAC multiple times
    • b312fa8c - Refactor linear allocator from LTE/NR; separate LTE/NR headers
    • 00a35aba - Delete ITTI-SIM
    • e77b5e88 - Transfer Initial UL RRC Message through internal F1
    • 68f840cd - gNB RRC: handle F1AP_UL_RRC_MESSAGE

    Compare with previous version

  • OAI RAN-CI-develop build (3492): Some Changed files in Merge Request DO NOT follow OAI Formatting Rules

  • Robert Schmidt added 412 commits

    added 412 commits

    • 68f840cd...6d030ea2 - 405 commits from branch develop
    • 9735a8b0 - Use F1 DL RRC message transfer internally for RRCSetup
    • 977ff7e7 - Add MAC-RRC UL stubs for F1AP and direct
    • 83c85fbc - Do not initialize MAC multiple times
    • 29662065 - Refactor linear allocator from LTE/NR; separate LTE/NR headers
    • 9c1a89a1 - Delete ITTI-SIM
    • 70b99ee8 - Transfer Initial UL RRC Message through internal F1
    • 02e625d9 - gNB RRC: handle F1AP_UL_RRC_MESSAGE

    Compare with previous version

  • OAI RAN-CI-develop build (3620): Some Changed files in Merge Request DO NOT follow OAI Formatting Rules

  • Author Maintainer

    @Cedric.Roux you can start/finalize the review of this one.

  • Robert Schmidt added 25 commits

    added 25 commits

    • 02e625d9...50916825 - 18 commits from branch develop
    • 8c84e19e - Use F1 DL RRC message transfer internally for RRCSetup
    • c09e19cb - Add MAC-RRC UL stubs for F1AP and direct
    • 334608c0 - Do not initialize MAC multiple times
    • b6e5e398 - Refactor linear allocator from LTE/NR; separate LTE/NR headers
    • d6427624 - Delete ITTI-SIM
    • 83270fdd - Transfer Initial UL RRC Message through internal F1
    • 571cd06f - gNB RRC: handle F1AP_UL_RRC_MESSAGE

    Compare with previous version

  • OAI RAN-CI-develop build (3651): Some Changed files in Merge Request DO NOT follow OAI Formatting Rules

  • Robert Schmidt mentioned in merge request !1613 (merged)

    mentioned in merge request !1613 (merged)

  • changed milestone to %REVIEW_IN_PROGRESS

  • works with accelleran + cumucore + cots ue

  • Code Review by: Cédric Roux

    • IMPACT on FUNCTIONAL CODE
      • The code change does respect architecture/protocol split
      • Abnormal exits are properly handled
      • Coding Style Issues
        • Added DEAD Code
        • Improper logging
        • Added useless debug code
        • Duplication of an existing function
        • Indentation is not respected
        • Insufficient in-code comments / code readability
        • Any other coding style issue
      • A new tool/lib/package has been introduced (blocking, subject to negotiation)
    • TESTING (The Merge Request requires additional testing)
      • Additional testing is present in the Merge Request (Best)
      • The contributor provides a framework/hints for testing
      • New testing means need to be developed
    • DOCUMENTATION (The Merge Request requires additional documentation)
      • Feature Set documentation update needed
        • DONE
        • NOT DONE
      • Wiki tutorial / in-repo usage documentation needed
        • DONE
        • NOT DONE
      • Added/Modified/Removed script/build/runtime option(s)
        • Help UPDATED
        • Help NOT UPDATED

    Recommendations:

    looks fine. openair du + accelleran cu + cumucore core + cots ue is as functional as it is with develop (plus some hacks I will cleanup soon).

    This should be rebased on top of develop, there are some minor conflicts.

    If the CI is ok for the rest of the system, then: good to go.

    Edited by Cédric Roux
  • Robert Schmidt added 234 commits

    added 234 commits

    • 571cd06f...4154e9e9 - 227 commits from branch develop
    • f75cdbca - Use F1 DL RRC message transfer internally for RRCSetup
    • f52809a8 - Add MAC-RRC UL stubs for F1AP and direct
    • 0c9006ec - Do not initialize MAC multiple times
    • 52dbc6fe - Refactor linear allocator from LTE/NR; separate LTE/NR headers
    • a126cd12 - Delete ITTI-SIM
    • 18a68387 - Transfer Initial UL RRC Message through internal F1
    • 9622a56b - gNB RRC: handle F1AP_UL_RRC_MESSAGE

    Compare with previous version

  • OAI RAN-CI-develop build (3832): Some Changed files in Merge Request DO NOT follow OAI Formatting Rules

  • Robert Schmidt changed title from Use F1 internally: RRC Message Transfer to WIP: Use F1 internally: RRC Message Transfer

    changed title from Use F1 internally: RRC Message Transfer to WIP: Use F1 internally: RRC Message Transfer

  • Robert Schmidt changed title from WIP: Use F1 internally: RRC Message Transfer to Use F1 internally: RRC Message Transfer

    changed title from WIP: Use F1 internally: RRC Message Transfer to Use F1 internally: RRC Message Transfer

  • OAI RAN-CI-develop build (3835): Some Changed files in Merge Request DO NOT follow OAI Formatting Rules

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading