Skip to content
Snippets Groups Projects

Draft: fix tests for log2_approx and log2_approx64

Merged Thomas Schlichter requested to merge fix_log2_approx_tests into develop
All threads resolved!
  • skip the test log2_approx.complete when using ctest
    • this test takes too much time to run
  • fix test log2_approx64.boundaries
    • The test was actually never executed correctly (unsigned -10 is never <= 10), and log2_approx64_ref() was not accurate enough.
    • Therefore replace it by directly comparing one value above and one value below each rounding boundary.
  • add test log2_approx.boundaries

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • rest ok, let's see CI and if good, we put it into !3014 (merged)

  • Robert Schmidt marked this merge request as draft

    marked this merge request as draft

  • added 3 commits

    • 6bf68c81 - skip the test log2_approx.complete when using ctest
    • d6f9bcd1 - fix test log2_approx64.boundaries
    • 28656a1a - add test log2_approx.boundaries

    Compare with previous version

  • Robert Schmidt resolved all threads

    resolved all threads

  • changed milestone to %OK_TO_BE_MERGED

  • Robert Schmidt mentioned in merge request !3014 (merged)

    mentioned in merge request !3014 (merged)

  • Robert Schmidt merged with merge request !3014 (merged)

    merged with merge request !3014 (merged)

  • Robert Schmidt mentioned in commit d8a6c5c9

    mentioned in commit d8a6c5c9

  • Please register or sign in to reply
    Loading