... | ... | @@ -12,11 +12,9 @@ |
|
|
</tr>
|
|
|
</table>
|
|
|
|
|
|
## Table of Contents ##
|
|
|
## Committee Role ##
|
|
|
|
|
|
|
|
|
|
|
|
The Technical Commitee is responsible for the following tasks:
|
|
|
The Technical Committee is responsible for the following tasks:
|
|
|
|
|
|
1. Review ticket upon creation to ensure [Ticket Policy Guidelines](policy/ticket-policy) are followed
|
|
|
2. Add a new project card in the “In Progress” projects in OAI Weekly Developers Meeting to track progress of Issue opened in the Ticket
|
... | ... | @@ -33,25 +31,28 @@ The Technical Commitee is responsible for the following tasks: |
|
|
7. Review all the policies to be in-line with state-of-the-art development tools
|
|
|
|
|
|
|
|
|
## MR and Review Rules ##
|
|
|
|
|
|
The CI passing on the MR is a pre-requisite to start the review process.
|
|
|
|
|
|
During a Merge-Request, one or several TC members are tasked to perform a human code review.
|
|
|
This review objective is to check things that were not automatically checked by CI and guarantee a qualitative level of the contributions.
|
|
|
The objective of the review is to check things that were not automatically checked by CI, guarantee a qualitative level of the current contributions and improve the quality of the future ones.
|
|
|
|
|
|
In principle, the review occurs before the final merge to develop branch, although a preliminary merge into the integration branch is possible while the review is on going, in order to detect potential issues and parallelize integration work.
|
|
|
|
|
|
The review form in markdown format is public and attached to the merge request.
|
|
|
|
|
|
The outcome of the review is in 2 parts:
|
|
|
- an 4 level integration status : accepted / minor revisions required / major revisions required / rejected
|
|
|
- a 4 level integration status : accepted / minor revisions required / major revisions required / rejected
|
|
|
- a recommendation status : the reviewer provides the contributor with suggestions to enhance/improve his/her work in the future
|
|
|
|
|
|
We highly recommend to submit small granular contributions rather than large ones.
|
|
|
The goal is to make the review and integration loop as short as possible.
|
|
|
|
|
|
When preparing a contribution that is larger than average, the developper is reponsible to warn the OAI team, so that the review work can start as early as possible and run in parallele to the contribution finalization. Failing to do so, there is a risk that the integration of his/her work remains on hold/under review for a longer time.
|
|
|
When preparing a contribution that is larger than average, the developer is reponsible for warning the OAI team, so that the review work can start as early as possible and run in parallele to the contribution finalization. Failing to do so, there is a risk that the integration of his/her work remains on hold/under review for a longer time.
|
|
|
|
|
|
|
|
|
## Review form ##
|
|
|
|
|
|
Form to use by copying/pasting into a comment on the Merge Request Web page:
|
|
|
|
... | ... | |