... | ... | @@ -70,7 +70,7 @@ The idea is to start the review early enough so that: |
|
|
The review form is in markdown format, is public and is attached to the merge request.
|
|
|
|
|
|
The outcome of the review is in 2 parts:
|
|
|
- A 4 level integration status : accepted / minor revisions required / major revisions required / rejected
|
|
|
- A 4 level integration status : accepted / minor revisions required / major revisions required / rejected
|
|
|
The 2 first levels will allow the contribution to be approved.
|
|
|
- A recommendation status : the reviewer provides the contributor with suggestions to enhance/improve his/her work for the current merge or in the future
|
|
|
|
... | ... | @@ -82,7 +82,7 @@ When preparing a contribution that is larger than average, the developer is resp |
|
|
|
|
|
## Review form ##
|
|
|
|
|
|
Form to use by copying/pasting into a comment on the Merge Request Web page:
|
|
|
Please use this form by copying/pasting into a comment on the Merge Request Web page:
|
|
|
|
|
|
```markdown
|
|
|
|
... | ... | @@ -142,7 +142,7 @@ Example after pasting into a comment: |
|
|
* [ ] **TESTING** (The Merge Request requires additional testing)
|
|
|
- [ ] Additional testing is present in the Merge Request
|
|
|
- [ ] The contributor provides a framework for testing
|
|
|
- [ ] New testing mean needs to be developed
|
|
|
- [ ] New testing means need to be developed
|
|
|
* [ ] **DOCUMENTATION** (The Merge Request requires additional documentation)
|
|
|
- [ ] Feature Set documentation update needed
|
|
|
* [ ] DONE
|
... | ... | |